From b453e1f2d1e2fefbee93c4573e6ffcf8897bf319 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi Date: Tue, 24 Oct 2023 14:47:24 +0900 Subject: [PATCH v6 2/2] Remove short sleep from 001_start_stop.pl Previous commits ensures reliable detection whether the postmaster has really started or not, so the short sleep in a test is not needed anymore. It was originally introduced by 6bcce258. --- src/bin/pg_ctl/t/001_start_stop.pl | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/bin/pg_ctl/t/001_start_stop.pl b/src/bin/pg_ctl/t/001_start_stop.pl index fd56bf7706..b50bd30a12 100644 --- a/src/bin/pg_ctl/t/001_start_stop.pl +++ b/src/bin/pg_ctl/t/001_start_stop.pl @@ -46,11 +46,6 @@ my $ctlcmd = [ ]; command_like($ctlcmd, qr/done.*server started/s, 'pg_ctl start'); -# sleep here is because Windows builds can't check postmaster.pid exactly, -# so they may mistake a pre-existing postmaster.pid for one created by the -# postmaster they start. Waiting more than the 2 seconds slop time allowed -# by wait_for_postmaster() prevents that mistake. -sleep 3 if ($windows_os); command_fails([ 'pg_ctl', 'start', '-D', "$tempdir/data" ], 'second pg_ctl start fails'); command_ok([ 'pg_ctl', 'stop', '-D', "$tempdir/data" ], 'pg_ctl stop'); -- 2.39.3