From 02c6e135f314d20885ae42d4594e2e2b46970a9f Mon Sep 17 00:00:00 2001 From: Richard Guo Date: Mon, 4 Dec 2023 16:27:08 +0800 Subject: [PATCH v1] Fix comment about cross-checking the varnullingrels The cross-check is not limited to debugging builds. Oversight in commit 867be9c07 (which should get reverted along with that, if we ever do revert it). --- src/backend/optimizer/plan/setrefs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/backend/optimizer/plan/setrefs.c b/src/backend/optimizer/plan/setrefs.c index 4bb68ac90e..112513c274 100644 --- a/src/backend/optimizer/plan/setrefs.c +++ b/src/backend/optimizer/plan/setrefs.c @@ -2760,11 +2760,11 @@ build_tlist_index_other_vars(List *tlist, int ignore_rel) * Also ensure that varnosyn is incremented by rtoffset. * If no match, return NULL. * - * In debugging builds, we cross-check the varnullingrels of the subplan - * output Var based on nrm_match. Most call sites should pass NRM_EQUAL - * indicating we expect an exact match. However, there are places where - * we haven't cleaned things up completely, and we have to settle for - * allowing subset or superset matches. + * We cross-check the varnullingrels of the subplan output Var based on + * nrm_match. Most call sites should pass NRM_EQUAL indicating we expect + * an exact match. However, there are places where we haven't cleaned + * things up completely, and we have to settle for allowing subset or + * superset matches. */ static Var * search_indexed_tlist_for_var(Var *var, indexed_tlist *itlist, -- 2.31.0