From f6e8262f3f9f33fe73c4cc916c2183998b021e57 Mon Sep 17 00:00:00 2001 From: Richard Guo Date: Thu, 31 Aug 2023 16:23:24 +0800 Subject: [PATCH v1] Replace more MemSet calls with struct initialization --- src/backend/parser/parse_target.c | 3 +-- src/backend/utils/adt/pgstatfuncs.c | 8 ++------ 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/backend/parser/parse_target.c b/src/backend/parser/parse_target.c index 57247de363..9aaf771913 100644 --- a/src/backend/parser/parse_target.c +++ b/src/backend/parser/parse_target.c @@ -1643,10 +1643,9 @@ expandRecordVariable(ParseState *pstate, Var *var, int levelsup) * in step with varlevelsup in the CTE; furthermore it * could be an outer CTE. */ - ParseState mypstate; + ParseState mypstate = {0}; Index levelsup; - MemSet(&mypstate, 0, sizeof(mypstate)); /* this loop must work, since GetCTEForRTE did */ for (levelsup = 0; levelsup < rte->ctelevelsup + netlevelsup; diff --git a/src/backend/utils/adt/pgstatfuncs.c b/src/backend/utils/adt/pgstatfuncs.c index 2b9742ad21..586b2d1b21 100644 --- a/src/backend/utils/adt/pgstatfuncs.c +++ b/src/backend/utils/adt/pgstatfuncs.c @@ -709,15 +709,11 @@ pg_stat_get_backend_subxact(PG_FUNCTION_ARGS) { #define PG_STAT_GET_SUBXACT_COLS 2 TupleDesc tupdesc; - Datum values[PG_STAT_GET_SUBXACT_COLS]; - bool nulls[PG_STAT_GET_SUBXACT_COLS]; + Datum values[PG_STAT_GET_SUBXACT_COLS] = {0}; + bool nulls[PG_STAT_GET_SUBXACT_COLS] = {0}; int32 beid = PG_GETARG_INT32(0); LocalPgBackendStatus *local_beentry; - /* Initialise values and NULL flags arrays */ - MemSet(values, 0, sizeof(values)); - MemSet(nulls, 0, sizeof(nulls)); - /* Initialise attributes information in the tuple descriptor */ tupdesc = CreateTemplateTupleDesc(PG_STAT_GET_SUBXACT_COLS); TupleDescInitEntry(tupdesc, (AttrNumber) 1, "subxact_count", -- 2.31.0