From 18ffbcc81c75525c73930ad3b5a63ae0873d2381 Mon Sep 17 00:00:00 2001 From: Peter Geoghegan Date: Tue, 31 Jul 2018 18:33:30 -0700 Subject: [PATCH] Add table relcache invalidation to index builds. It's necessary to make sure that owning tables have a relcache invalidation prior to advancing the command counter to make newly-entered catalog tuples for the index visible. inval.c must be able to roll back the local caches in the event of transaction abort. There is only a problem when CREATE INDEX transactions abort, since there is a generic invalidation once we reach index_update_stats(). This bug is of long standing. Problems were made much more likely by the addition of parallel CREATE INDEX (commit 9da0cc35284), but it is strongly suspected that similar problems can be triggered without involving plan_create_index_workers(). Bug diagnosed by Andres Freund. Author: Peter Geoghegan Reported-By: Luca Ferrari Discussion: https://postgr.es/m/CAKoxK+5fVodiCtMsXKV_1YAKXbzwSfp7DgDqUmcUAzeAhf=HEQ@mail.gmail.com Backpatch: 9.3- --- src/backend/catalog/index.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c index 8b276bc430..7036d72bd6 100644 --- a/src/backend/catalog/index.c +++ b/src/backend/catalog/index.c @@ -1137,6 +1137,19 @@ index_create(Relation heapRelation, InvokeObjectPostCreateHookArg(RelationRelationId, indexRelationId, 0, is_internal); + /* + * Invalidate the relcache for the owning table, so that any local + * relcache entry for the new index built after CommandCounterIncrement + * won't become inconsistent in the event of transaction abort. inval.c + * must be able to roll back the local caches when aborting. Clearly it + * isn't useful to create an index whose definition results in a relcache + * entry for the index being allocated before commit, but the local caches + * cannot be allowed to become inconsistent under any circumstances. + * (There is only an issue when transactions abort because we'll reach + * index_update_stats when they commit.) + */ + CacheInvalidateRelcache(heapRelation); + /* * Advance the command counter so that we can see the newly-entered * catalog tuples for the index. -- 2.17.1