From 652efe45665d91f2f4ae865dba078fcaffdc0a17 Mon Sep 17 00:00:00 2001 From: Euler Taveira Date: Fri, 27 May 2022 11:35:27 -0300 Subject: [PATCH v1 1/2] Ignore heap rewrites for materialized views in logical replication If you have a publication that specifies FOR ALL TABLES clause, a REFRESH MATERIALIZED VIEW can break your setup with the following message ERROR: logical replication target relation "public.pg_temp_NNN" does not exist Commit 1a499c2520 introduces a heuristic to prevent that transient heaps (due to table rewrites) are included for a FOR ALL TABLES publication. However, it forgot to exclude materialized views (heap rewrites occurs when you execute REFRESH MATERIALIZED VIEW). Since materialized views are not supported in logical decoding, it is appropriate to filter them too. As explained in the commit message, a more robust solution was included in version 11 (commit 325f2ec555), hence only version 10 is affected. --- src/backend/replication/pgoutput/pgoutput.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/backend/replication/pgoutput/pgoutput.c b/src/backend/replication/pgoutput/pgoutput.c index f96fde3df0..e03ff4a11e 100644 --- a/src/backend/replication/pgoutput/pgoutput.c +++ b/src/backend/replication/pgoutput/pgoutput.c @@ -540,7 +540,9 @@ get_rel_sync_entry(PGOutputData *data, Oid relid) if (sscanf(relname, "pg_temp_%u%n", &u, &n) == 1 && relname[n] == '\0') { - if (get_rel_relkind(u) == RELKIND_RELATION) + char relkind = get_rel_relkind(u); + + if (relkind == RELKIND_RELATION || relkind == RELKIND_MATVIEW) break; } } -- 2.30.2