Re: minor fix of elevel in fd.c - Mailing list pgsql-patches

From Qingqing Zhou
Subject Re: minor fix of elevel in fd.c
Date
Msg-id Pine.LNX.4.58.0606122143310.27449@eon.cs
Whole thread Raw
In response to Re: minor fix of elevel in fd.c  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: minor fix of elevel in fd.c
List pgsql-patches

On Mon, 12 Jun 2006, Tom Lane wrote:

> "Qingqing Zhou" <zhouqq@cs.toronto.edu> writes:
> > AllocateFile() and AllocateDir() should return the control to the caller
> > since we might want to upgrade the elevel.
>
> That is not what we do for upgrading errors.  Use a critical section in
> a caller that doesn't want elog(ERROR).
>

True, but current code just check the return value of AllocateABC() then
decide to upgrade elevel to FATAL. This is ok if we allow AllocateABC()
don't elog(ERROR) themselves.

Regards,
Qingqing



pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Bitmap index AM
Next
From: Tom Lane
Date:
Subject: Re: minor fix of elevel in fd.c