Re: Updated instrumentation patch - Mailing list pgsql-patches

From Dave Page
Subject Re: Updated instrumentation patch
Date
Msg-id E7F85A1B5FF8D44C8A1AF6885BC9A0E4850789@ratbert.vale-housing.co.uk
Whole thread Raw
In response to Updated instrumentation patch  ("Magnus Hagander" <mha@sollentuna.net>)
List pgsql-patches


-----Original Message-----
From: pgsql-patches-owner@postgresql.org on behalf of Tom Lane
Sent: Sat 7/30/2005 4:58 PM
To: Magnus Hagander
Cc: PostgreSQL-patches
Subject: Re: [PATCHES] Updated instrumentation patch

> None of these functions are getting into 8.1 anyway; we should be
> designing the long-term solution not making up short-lived hacks.

So, going back to pre 8.0, we fixed them so they don't work outside of the data directory as requested, yet they were
notincluded for unknown reasons. 

We revisited some weeks before prior to feature freeze, and I researched all issues raised and ask for clarification on
whatyou weren't happy with as all I'd found in the archives was a sentence along the lines of "I really don't see any
valuein these". I found no outstanding issues in the archives, nor did I receive any in response to my questions. 

Having received no further objections, the patch was added to the queue. As soon as Bruce starts to look at it,
presumablyto apply it, you decide it's an unnacceptable security problem, and say you'd be perfectly happy if there was
aGUC to disable the potentially dangerous functions. This info would have been nice before feature freeze, but, OK, I
appreciateyou're busy. 

Magnus updates the patch because he's yet another one of us that thinks this is useful functionality and adds the GUC
yousaid would make you happy with these functions. 

You then state, with no discussion at all, that they're not going into 8.1 anyway, despite us doing everything you have
asked.

I have two questions if I may:

1) Is there any point us working on any kind of enhanced API for remote admin in the future, or will the same treatment
begiven to that? 

2) Do you now have sole say over what does and doesn't go into the project?

I don't mean to be disrespectful - your hard work and skills are hugely appreciated by the whole community, but I know
fora fact that a number of them, who between them have contributed thousands of hours and lines of code to the project
(andI'm talking about the core project, never mind pgAdmin et al) cannot understand your apparent insistence on us not
providingremote admin capabilities. I think we simply need clarification on how the project works these days. 

Regards, Dave



pgsql-patches by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Re: Updated instrumentation patch
Next
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] Autovacuum loose ends