Re: guc.c and postgresql.conf.sample constistency check - Mailing list pgsql-patches

From Tom Lane
Subject Re: guc.c and postgresql.conf.sample constistency check
Date
Msg-id 5803.1023718693@sss.pgh.pa.us
Whole thread Raw
In response to Re: guc.c and postgresql.conf.sample constistency check  (Ron Snyder <snyder@roguewave.com>)
List pgsql-patches
Ron Snyder <snyder@roguewave.com> writes:
>> The catch is that some of these options (lc_*) are supposed
>> to be absent,
>> so it's not as easy as it seems.

> Hmm. Are you saying that lc_* are being pulled out of code, so shouldn't be
> in postgresql.conf.sample, or that they're staying in code but still
> shouldn't be in postgresql.conf.sample?

The lc_ items are actually inserted into postgresql.conf by initdb, so
they don't belong in the sample file.  There are a couple other items
that are deliberately undocumented (PreAuthDelay for one).  I think your
tool might be useful for catching unintentional omissions, but it'd have
to be tweaked to have a list of the intentional omissions.

> Here's a bit from guc.h:

It's generally unhelpful to quote a comment at its author ;-)

            regards, tom lane

pgsql-patches by date:

Previous
From: Ron Snyder
Date:
Subject: Re: guc.c and postgresql.conf.sample constistency check
Next
From: Katherine Ward
Date:
Subject: Superficial changes for Win32