Re: COPY-able sql log outputs - Mailing list pgsql-patches

From Magnus Hagander
Subject Re: COPY-able sql log outputs
Date
Msg-id 460E8481.3070707@hagander.net
Whole thread Raw
In response to Re: COPY-able sql log outputs  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> Then, it may be just me, but I find code like this:
>> !         sqllogFile = fopen(strcat(filename, ".sql"), "a");
>> very hard to read.
>
> Such coding should be rejected out of hand anyway --- can you say
> "buffer overrun"?

I was thinking that, but given that it only takes the config parameter
from postgresql.conf and no actual user input, I considered it less
important. But thinking twice, yeah, even in that case it shouldn't be
done, just to stay on the safe side.

//Magnus

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: COPY-able sql log outputs
Next
From: Andrew Dunstan
Date:
Subject: Re: Current enums patch