Re: [HACKERS] For review: Server instrumentation patch - Mailing list pgsql-patches

From Andreas Pflug
Subject Re: [HACKERS] For review: Server instrumentation patch
Date
Msg-id 42EE27BC.5080407@pse-consulting.de
Whole thread Raw
In response to Re: [HACKERS] For review: Server instrumentation patch  ("Dave Page" <dpage@vale-housing.co.uk>)
List pgsql-patches
Dave Page wrote:
>
>
>
>>-----Original Message-----
>>From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
>>Sent: 01 August 2005 03:26
>>To: Dave Page
>>Cc: PostgreSQL-patches
>>Subject: Re: [HACKERS] For review: Server instrumentation patch
>>
>>Dave Page wrote:
>>
>>>[Resent as the list seems to have rejected yesterdays attempt]
>>>
>>>As per Bruce's request, here's a copy of Andreas' server
>>>instrumentation patch for review. I've separated out the
>>>dbsize stuff and pg_terminate_backend is also not included.
>>>
>>>This version was generated against CVS today.
>>>
>>>As far as I can tell from review of comments made back to
>>>pre-8.0, all security and other concerns raised have been addressed.
>>
>>Here is a modified version of your patch that adds functions to do
>>configuration file reload, and log file rotation.
>
>
> OK, thanks. Are there any objections to adding pg_dir_ls() and
> pg_file_read() which will allow us to look at the log directory, and the
> logfiles themselves?

pg_dir_ls isn't necessary for reading the logfiles; pg_logdir_ls will do
this.

Regards,
Andreas

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] Autovacuum loose ends
Next
From: "Dave Page"
Date:
Subject: Re: [HACKERS] For review: Server instrumentation patch