Re: [HACKERS] Patch to log usage of temporary files - Mailing list pgsql-patches

From Andrew Dunstan
Subject Re: [HACKERS] Patch to log usage of temporary files
Date
Msg-id 3813.24.211.165.134.1167872727.squirrel@www.dunslane.net
Whole thread Raw
In response to Re: [HACKERS] Patch to log usage of temporary files  (Bill Moran <wmoran@collaborativefusion.com>)
Responses Re: [HACKERS] Patch to log usage of temporary files  (Bill Moran <wmoran@collaborativefusion.com>)
List pgsql-patches
Bill Moran wrote:
> Andrew Dunstan <andrew@dunslane.net> wrote:
>>
>> Bill Moran wrote:
>> > +         if (trace_temp_files != -1)
>> >
>>
>> Might be more robust to say
>>
>>     if (trace_temp_files >= 0)
>
> Because it would allow for the easy addition of more negative numbers
> with magic value?
>


because ISTM any negative number here should mean no action is to be
taken. Otherwise how else is it different from 0?

cheers

andrew


pgsql-patches by date:

Previous
From: Bill Moran
Date:
Subject: Re: [HACKERS] Patch to log usage of temporary files
Next
From: Euler Taveira de Oliveira
Date:
Subject: Re: xlog directory at initdb time