Re: [PATCHES] Interval aggregate regression failure - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Interval aggregate regression failure
Date
Msg-id 27363.1157076876@sss.pgh.pa.us
Whole thread Raw
Responses Re: [PATCHES] Interval aggregate regression failure  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> I am unclear about this report.  The patch was not meant to fix every
> interval issue, but merely to improve multiplication and division
> computations.  Does it do that?

According to Michael's last report, your patch fails under
--enable-integer-datetimes.

This is an issue where you have to be "as simple as possible, but no
simpler".  I think the approach you are proposing is too simple.
Michael's last patch here:
http://archives.postgresql.org/pgsql-patches/2006-08/msg00447.php
looks considerably more likely to lead to a workable answer.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: massive speedup on temp table creation/destruction?
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] Interval aggregate regression failure