Re: ldap: fix resource leak - Mailing list pgsql-patches

From Tom Lane
Subject Re: ldap: fix resource leak
Date
Msg-id 26557.1162772928@sss.pgh.pa.us
Whole thread Raw
In response to Re: ldap: fix resource leak  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: ldap: fix resource leak  (Neil Conway <neilc@samurai.com>)
List pgsql-patches
I wrote:
> ...  Not sure that
> this is actually a net win though, as a PANIC might well be considered a
> worse problem than a one-time leak of some LDAP state.

Come to think of it: either elog(ERROR) or a failure return from
CheckLDAPAuth is going to lead directly to backend exit, so the
whole thing is pretty much a cosmetic issue anyway.  I don't object
to adding the ldap_unbind calls, but I'd not recommend adding a large
pile of code.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: ldap: fix resource leak
Next
From: Neil Conway
Date:
Subject: Re: ldap: fix resource leak