Re: table/index fillfactor control - Mailing list pgsql-patches

From Tom Lane
Subject Re: table/index fillfactor control
Date
Msg-id 25057.1149648535@sss.pgh.pa.us
Whole thread Raw
In response to Re: table/index fillfactor control  (ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
List pgsql-patches
ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp> writes:
> "Jonah H. Harris" <jonah.harris@gmail.com> wrote:
>> There's 4 shift/reduce conflicts which I believe are caused by having
>> used WITH... did you plan to fix this?

> Thanks for pointing out. I realized it is a confliction between
> WITH OIDS and WITH (options).

> I'll try to treat CreateStmt.hasoids as one of the options internally,
> with SQL-level backward compatibility.

There was some discussion recently about how we'll have to make WITH
a fully reserved keyword eventually anyway to handle SQL99 recursive
queries.  I'm not sure if that's really true, but reserving WITH is
a fallback position we should consider, if avoiding the shift/reduce
conflict seems unreasonably messy otherwise.

            regards, tom lane

pgsql-patches by date:

Previous
From: ITAGAKI Takahiro
Date:
Subject: Re: table/index fillfactor control
Next
From: Bruce Momjian
Date:
Subject: Re: [HACKERS] Win32 sysconfig -> pg_service.conf