Re: [HACKERS] Issues with generate_series using integer boundaries - Mailing list pgsql-general

From Tom Lane
Subject Re: [HACKERS] Issues with generate_series using integer boundaries
Date
Msg-id 20925.1308334513@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Issues with generate_series using integer boundaries  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-general
Robert Haas <robertmhaas@gmail.com> writes:
> So, I finally got around to look at this, and I think there is a
> simpler solution.  When an overflow occurs while calculating the next
> value, that just means that the value we're about to return is the
> last one that should be generated.  So we just need to frob the
> context state so that the next call will decide we're done.  There are
> any of number of ways to do that; I just picked what looked like the
> easiest one.

+1 for this solution.

BTW, there was some mention of changing the timestamp versions of
generate_series as well, but right offhand I'm not convinced that
those need any change.  I think you'll get overflow detection there
automatically from the functions being used --- and if not, it's a
bug in those functions, not in generate_series.

            regards, tom lane

pgsql-general by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Issues with generate_series using integer boundaries
Next
From: Robert Haas
Date:
Subject: Re: [HACKERS] Issues with generate_series using integer boundaries