Re: Change draft gmake control - Mailing list pgsql-docs

From Bruce Momjian
Subject Re: Change draft gmake control
Date
Msg-id 200701272247.l0RMl1t13872@momjian.us
Whole thread Raw
In response to Re: Change draft gmake control  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-docs
Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Well, if 'draft' was only for html, I could see suggesting just 'gmake
> > draft', but 'draft' can be used for Postscript and PDF too.
>
> But those aren't cases where saving some typing is useful (in fact,
> I'd bet money that no one will ever use them).  Draft runs with html
> output are highly useful, and like Peter I think "make draft" ought
> to work for that.

OK, if that's what people want.  Patch attached and applied, docs
updated.

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +
Index: sgml/Makefile
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/Makefile,v
retrieving revision 1.93
diff -c -r1.93 Makefile
*** sgml/Makefile    26 Jan 2007 23:51:39 -0000    1.93
--- sgml/Makefile    27 Jan 2007 22:33:17 -0000
***************
*** 99,104 ****
--- 99,110 ----
  endif


+ # The draft rule calls gmake again and sets the DRAFT variable.
+ # This seems to be the only way to set gmake variables in a rule.
+ draft:
+     @$(MAKE) DRAFT="Y" html
+
+
  COLLATEINDEX := LC_ALL=C $(PERL) $(COLLATEINDEX) -f -g

  # bookindex.sgml is required so there is a proper index for all output formats
Index: sgml/docguide.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/docguide.sgml,v
retrieving revision 1.66
diff -c -r1.66 docguide.sgml
*** sgml/docguide.sgml    26 Jan 2007 22:23:50 -0000    1.66
--- sgml/docguide.sgml    27 Jan 2007 22:33:17 -0000
***************
*** 546,552 ****
      stages.  If you do not care about the index, and just want to
      proof-read the output, use <literal>draft</>:
  <screen>
! <prompt>doc/src/sgml$ </prompt><userinput>gmake DRAFT=Y html</userinput>
  </screen>
     </para>

--- 546,552 ----
      stages.  If you do not care about the index, and just want to
      proof-read the output, use <literal>draft</>:
  <screen>
! <prompt>doc/src/sgml$ </prompt><userinput>gmake draft</userinput>
  </screen>
     </para>


pgsql-docs by date:

Previous
From: Tom Lane
Date:
Subject: Re: Change draft gmake control
Next
From: Tom Lane
Date:
Subject: Re: [GENERAL] Password issue revisited