Re: Allow commenting of variables in postgresql.conf to - try2 - Mailing list pgsql-patches

From Joachim Wieland
Subject Re: Allow commenting of variables in postgresql.conf to - try2
Date
Msg-id 20060531175816.GA4225@mcknight.de
Whole thread Raw
In response to Re: Allow commenting of variables in postgresql.conf to -  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
Responses Re: Allow commenting of variables in postgresql.conf to -  (Zdenek Kotala <Zdenek.Kotala@Sun.COM>)
List pgsql-patches
Zdenek,

On Wed, May 31, 2006 at 06:13:04PM +0200, Zdenek Kotala wrote:
> Joachim, could you explain me second point? I  cannot determine
> described problem. By my opinion my patch does not change this behavior.

I guess what I saw was another phenomenon:

I do the following:

- vi postgresql.conf => "allow_system_table_mods = true"
- start postmaster
- vi postgresql.conf => "# allow_system_table_mods = true" (commented)
- killall -HUP postmaster

Then I get _no_ message. After another killall -HUP I do indeed get a
message. So I don't get it just for the first time which is strange, do you
see that as well?

However the message I get is that it got reset to its default value which is
wrong because its a PGC_POSTMASTER variable that can only be set at server
start (set_config_option() returns true in this case as well).

Consequently I expect to get it for every other signal I send (because the
old value is still active and differs from what is in the configuration
file).


Joachim


pgsql-patches by date:

Previous
From: Martijn van Oosterhout
Date:
Subject: Re: [PATCH] Magic block for modules
Next
From: "Marko Kreen"
Date:
Subject: Re: [PATCH] Magic block for modules