Re: [HACKERS] Enhanced containment selectivity function - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [HACKERS] Enhanced containment selectivity function
Date
Msg-id 200604262026.k3QKQr301927@candle.pha.pa.us
Whole thread Raw
In response to Re: [HACKERS] Enhanced containment selectivity function  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Enhanced containment selectivity function
List pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Cleaned-up patch attached and applied.
>
> Please revert this patch.  This has not been updated to satisfy the
> previous agreement about how it should work.  It is completely
> inappropriate to be dropping code that's specific to one contrib module
> into the core selfuncs.c file.  What we had agreed to do was look at
> exporting some of the currently-static functions in selfuncs.c so that
> contrib modules could make use of them from outside the core --- but
> this patch doesn't do that.

OK, reverted, but I saw it using contsel() so I figured we were allowing
it, but I see contsel() is used by our "box", so ltree was just using
something that was already there.  Let me see if I can break out the new
selectivity function into /contrib.

--
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Enhanced containment selectivity function
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Enhanced containment selectivity function