Re: [pgsql-hackers-win32] snprintf causes regression - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: [pgsql-hackers-win32] snprintf causes regression
Date
Msg-id 200503110410.j2B4ACx27187@candle.pha.pa.us
Whole thread Raw
In response to Re: [pgsql-hackers-win32] snprintf causes regression  (pgsql@mohawksoft.com)
List pgsql-hackers
pgsql@mohawksoft.com wrote:
> > Tom Lane wrote:
> >> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> >> > Please see my posting about using a macro for snprintf.  If the
> >> current
> >> > implementation of snprintf is enough for our existing translation
> >> users
> >> > we probably don't need to add anything more to it because snprintf
> >> will
> >> > not be exported to client applications.
> >>
> >> The CVS-tip implementation is fundamentally broken and won't work even
> >> for our internal uses.  I've not wasted time complaining about it
> >> because I thought we were going to replace it.  If we can't find a
> >> usable replacement then we're going to have to put a lot of effort
> >> into fixing what's there.  On the whole I think the effort would be
> >> better spent importing someone else's solution.
> >
> > Oh, so our existing implementation doesn't even meet our needs. OK.
>
> Wasn't the issue about odd behavior of the Win32 linker choosing the wrong
> vnsprintf?

Ah, but with my new patch to be applied tomorrow to use macros and
rename to pg_snprintf there no longer is any conflict with the system
versions of these functions.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests
Next
From: Nicolai Tufar
Date:
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests to fail