Re: CLUSTER patch - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: CLUSTER patch
Date
Msg-id 200207181511.g6IFBro12021@candle.pha.pa.us
Whole thread Raw
In response to Re: CLUSTER patch  (Alvaro Herrera <alvherre@atentus.com>)
Responses Re: CLUSTER patch  (Alvaro Herrera <alvherre@atentus.com>)
List pgsql-patches
Doc patch mentions problem with dependency after CLUSTER.  Patch removed
from queue.

---------------------------------------------------------------------------

Alvaro Herrera wrote:
> Tom Lane dijo:
>
> > Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > > This case is actually more complicated because after the swap, pg_class
> > > still says thisxactonly but the relfilenode points to non-thisactonly
> > > buffers, and via versa.
> >
> > pg_class doesn't say anything (if it did, we could make relcache.c
> > track it).
> >
> > But yes, the problem is that myxactonly has to line up with where the
> > buffers are stored.  As I mentioned, I think it would work to flush out
> > all buffers for both rels before doing the swap.
>
> It does indeed work.  Actually, I tried to do that before, but the fact
> that RelationFlushBuffers requires a firstDelBlock made me turn around.
>
> I attach a new patch against current cvs HEAD.  It works as far as I've
> tested it, but I may be missing some cases.  I'll post a documentation
> patch later if this gets applied.
>
> --
> Alvaro Herrera (<alvherre[a]atentus.com>)
> "Some men are heterosexual, and some are bisexual, and some
> men don't think about sex at all... they become lawyers" (Woody Allen)

Content-Description:

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: CLUSTER patch
Next
From: Bruce Momjian
Date:
Subject: Re: Between Node