Re: IPv6 Support for INET/CIDR types. - Mailing list pgsql-patches

From Vadim Kogan
Subject Re: IPv6 Support for INET/CIDR types.
Date
Msg-id 20020222111248.D29951@scam.xcf.berkeley.edu
Whole thread Raw
In response to Re: IPv6 Support for INET/CIDR types.  (Paul Vixie <paul@vix.com>)
List pgsql-patches
Ok. I've been a little bit out of the loop lately.

a) The original changes I had were made out of two parts:
    - inet_*_* part
    - postgres-specific part
b) I have made some choices there as to how to show/input things.
   Basically, any valid representation is understood. The output
   is as close as possible to the similar IPv4 outputs. Also, the
   the most compact version is used (but that's in inet_*_*).

If somebody has my original patches (WITH postgres-specific stuff), that'd
probably be a good starting point. In any case, I will try to produce
another diff today or sometime during this weekend. I will omit any changes
to inet_*_*, since bind now has proper version (and moreover, that version
is not the same as mine, since Paul rewrote some of the stuff).

Does anybody have a pointer to info on how to grow the second head? Or at
least one more hand...


On Fri, Feb 22, 2002 at 10:38:12AM -0800, Paul Vixie wrote:
> i completely respect postgres's need for consistency in the appearance
> of these presentation formats.  if they are different from bind's then
> i, as a consumer of postgresql, will learn to live with those differences.
> i do not, in other words, need to be convinced at all.  you guys found a
> format you like, and i will do everything i can to support it.
>
> i just want the support to occur in the postgres source code rather than
> in the bind source code.  there is an inet_*_*.c source file in the
> postgres sources which was originally a copy of bind's, but which has
> been modified to produce a different output format.  i (as an occasional
> contributor to postgres's development) propose that it would be easier
> to just import a new version of bind's inet_*_*.c file occasionally,
> and even teach "./configure" to note that it's already in libc (if it is)
> and if so use the libc version rather than the internal version.
>
> this implies that the part of postgres that calls this part of bind's
> library should "fix up" the return value to convert it to "postgres style."
>
> again, i am in complete support of postgres having its own style.  i just
> don't think postgres should have an incompatible variant of a BIND library
> function.  the stylistic variance should be applied in the postgres source,
> not to a copy of the BIND source.
>
> my problem is, i don't know exactly what the stylistic difference is,
> nor do i know how to "post-apply" it to the returned result from the BIND
> library, nor how to change "./configure" to notice and use the LIBC
> (or -lbind) version of these functions if they exist.  if someone else
> could take care of those deeper matters, then i would be completely happy
> to integrate vadim's ipv6 changes to the INET and CIDR data types.


Vadim.


Attachment

pgsql-patches by date:

Previous
From: Paul Vixie
Date:
Subject: Re: IPv6 Support for INET/CIDR types.
Next
From: Paul Vixie
Date:
Subject: Re: IPv6 Support for INET/CIDR types.