> > diff -u -r1.91 nodes.h
> > --- src/include/nodes/nodes.h 2001/06/19 22:39:12 1.91
> > +++ src/include/nodes/nodes.h 2001/07/16 09:35:35
> > @@ -158,7 +158,6 @@
> > T_DropStmt,
> > T_TruncateStmt,
> > T_CommentStmt,
> > - T_ExtendStmt,
> > T_FetchStmt,
> > T_IndexStmt,
> > T_ProcedureStmt,
>
> This is not good --- we try to avoid renumbering existing node types.
> (Not for any essential reason, perhaps, but why risk breaking anything?)
> My practice when removing a node type is to change the nodes.h entry
> like this:
>
> T_RemoveOperStmt,
> T_RemoveStmt_XXX, /* not used anymore; tag# available */
> T_RenameStmt,
>
> Adding the _XXX is sufficient to ensure that any missed uses of the
> typecode in the source will yield compile errors.
>
> Otherwise it looks OK.
I always rip that stuff out. We do an initdb for every release. What
could break by renumbering those nodes?
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
