Re: [JDBC] Patch to set timezone once instead of every call - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: [JDBC] Patch to set timezone once instead of every call
Date
Msg-id 200107021620.f62GKeF09310@candle.pha.pa.us
Whole thread Raw
In response to Patch to set timezone once instead of every call  (Barry Lind <barry@xythos.com>)
List pgsql-patches
Your patch has been added to the PostgreSQL unapplied patches list at:

    http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

> This patch moves the setting of the timezone on the SimpleDateFormat
> object inside the initialization section instead of doing it everytime
> the setTimestamp method is called.  Thanks to Dave Harkness for this
> suggestion.
>
> thanks,
> --Barry
>

> *** ./interfaces/jdbc/org/postgresql/jdbc2/PreparedStatement.java.orig    Sat Jun 30 17:19:36 2001
> --- ./interfaces/jdbc/org/postgresql/jdbc2/PreparedStatement.java    Sat Jun 30 17:20:47 2001
> ***************
> *** 369,377 ****
>             SimpleDateFormat df = (SimpleDateFormat) tl_tsdf.get();
>             if(df==null) {
>               df = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
>               tl_tsdf.set(df);
>             }
> -           df.setTimeZone(TimeZone.getTimeZone("GMT"));
>
>             // Use the shared StringBuffer
>             synchronized(sbuf) {
> --- 369,377 ----
>             SimpleDateFormat df = (SimpleDateFormat) tl_tsdf.get();
>             if(df==null) {
>               df = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
> +             df.setTimeZone(TimeZone.getTimeZone("GMT"));
>               tl_tsdf.set(df);
>             }
>
>             // Use the shared StringBuffer
>             synchronized(sbuf) {

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo@postgresql.org so that your
> message can get through to the mailing list cleanly

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [JDBC] Patch to remove connection hook and JDK 1.3 dependencies
Next
From: Bruce Momjian
Date:
Subject: Re: [JDBC] Patch for dead code in JDBC PG_Stream