Re: Fix command completion for CREATE TABEL ... AS - Mailing list pgsql-patches

From Tom Lane
Subject Re: Fix command completion for CREATE TABEL ... AS
Date
Msg-id 17962.1014400550@sss.pgh.pa.us
Whole thread Raw
In response to Fix command completion for CREATE TABEL ... AS  (Fernando Nasser <fnasser@redhat.com>)
List pgsql-patches
Fernando Nasser <fnasser@redhat.com> writes:
> This patch fixes the response for a CREATE TABLE ... AS statement.

Do we really need the overhead of adding a new parse node type just
to change the command tag returned for a CREATE ... AS?

If your definition of "correct command tag" is "first word of what the
user typed", we could get that more directly and reliably with a little
bit of lexer hacking; we should not base it on the parse tree at all.
But I'm not convinced that this is necessary or appropriate.

On the other hand, maybe you've got some other goal in mind that makes
it worthwhile to have distinct parse representations for SELECT ... INTO
and CREATE ... AS.  But please explain what the motivation is for
changing this.

            regards, tom lane

pgsql-patches by date:

Previous
From: "Greg Sabino Mullane"
Date:
Subject: Re: Automatic transactions in psql
Next
From: Bruce Momjian
Date:
Subject: Re: IPv6 Support for INET/CIDR types.