Re: [HACKERS] Recent SIGSEGV failures in buildfarm HEAD - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] Recent SIGSEGV failures in buildfarm HEAD
Date
Msg-id 16170.1167772297@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Recent SIGSEGV failures in buildfarm HEAD  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: [HACKERS] Recent SIGSEGV failures in buildfarm HEAD  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-patches
Andrew Dunstan <andrew@dunslane.net> writes:
> Revised patch attached, doing just this. I will apply it soon unless
> there are objections.

Probably a good idea to check defined(HAVE_GETRLIMIT) && defined(RLIMIT_CORE),
rather than naively assuming every getrlimit implementation supports
that particular setting.  Also, should the -c option exist but just not
do anything if the platform doesn't support it?  As is, you're making it
impossible to just specify -c without worrying if it does anything.

The documentation fails to list the long form of the switch
(--corefiles, which should probably really be --core-files for consistency).
There's a typo in this message, too:

+                 _("%s: cannot set core size,: disallowed by hard limit.\n"),

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Patch(es) to expose n_live_tuples and
Next
From: Andrew Dunstan
Date:
Subject: Re: [HACKERS] Recent SIGSEGV failures in buildfarm HEAD