Re: Assertion failure with small block sizes - Mailing list pgsql-patches

From Tom Lane
Subject Re: Assertion failure with small block sizes
Date
Msg-id 1323.1192501967@sss.pgh.pa.us
Whole thread Raw
In response to Re: Assertion failure with small block sizes  (Gregory Stark <stark@enterprisedb.com>)
Responses Re: Assertion failure with small block sizes  (Gregory Stark <stark@enterprisedb.com>)
List pgsql-patches
Gregory Stark <stark@enterprisedb.com> writes:
> If I push the TOAST_TUPLES_PER_PAGE up to 16 I get another failure on the same
> line from trying to toast a sequence. If I add RELKIND_SEQUENCE to the
> assertion then it passes all regression tests even if I push
> TOAST_TUPLES_PER_PAGE up to 1024 -- ie, try to toast everything as far as
> possible. Perhaps heapam.c:1761 should just check for RELKIND_SEQUENCE as
> well.

Hmm.  I'm inclined to reverse the tests (there are 3 not just 1) in
heapam.c, so that it explicitly tries to toast only in plain tables,
rather than adding more exclusion cases.  Thoughts?

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] quote_literal with NULL
Next
From: Gregory Stark
Date:
Subject: Re: Assertion failure with small block sizes