Re: parse_expr.c:typecast_expression:return immediate on NULL input - Mailing list pgsql-patches

From Tom Lane
Subject Re: parse_expr.c:typecast_expression:return immediate on NULL input
Date
Msg-id 11540.1195837957@sss.pgh.pa.us
Whole thread Raw
In response to parse_expr.c:typecast_expression:return immediate on NULL input  (Hannes Eder <Hannes@HannesEder.net>)
Responses Re: parse_expr.c:typecast_expression:return immediate on NULL input  ("Hannes Eder" <Hannes@HannesEder.net>)
List pgsql-patches
Hannes Eder <Hannes@HannesEder.net> writes:
> in parse_expr.c:typecast_expression: return immediate on NULL input,
> i.e. do not lookup target type Oid as it is not required.

I think the existing ordering is intentional, to detect and error out
if the given typename is bogus.

It's fairly likely that the test for InvalidOid is dead code anyway,
but it's cheap enough that I'm not in a hurry to take it out.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Cleaner API for appendStringInfoVA
Next
From: "Marko Kreen"
Date:
Subject: Re: Cleaner API for appendStringInfoVA