Re: Tuple sampling - Mailing list pgsql-patches

From Tom Lane
Subject Re: Tuple sampling
Date
Msg-id 10795.1085406222@sss.pgh.pa.us
Whole thread Raw
In response to Re: Tuple sampling  (Manfred Koizar <mkoi-pg@aon.at>)
List pgsql-patches
Manfred Koizar <mkoi-pg@aon.at> writes:
> Performance was not the primary motivation.  I found it confusing to
> have doubles everywhere and not to know whether a variable is declared
> as double, because
>   . we need the fractional part (e.g. a probability)
>   . or it should be able to hold an integral value of more than 32 bits.
> So I just invented my own datatype for huge integers.

Well, if you want to "typedef double TupleCount" as a documentation aid,
I don't object, but let's not do it just locally in analyze.c.  There
are a bunch of other places that do the same thing.

            regards, tom lane

pgsql-patches by date:

Previous
From: Neil Conway
Date:
Subject: updated list rewrite
Next
From: Bruce Momjian
Date:
Subject: Re: add build utilities in default install