Re: [BUGS] Bug#333854: pg_group file update problems - Mailing list pgsql-patches

From Tom Lane
Subject Re: [BUGS] Bug#333854: pg_group file update problems
Date
Msg-id 10374.1129305332@sss.pgh.pa.us
Whole thread Raw
In response to Re: [BUGS] Bug#333854: pg_group file update problems  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: [BUGS] Bug#333854: pg_group file update problems  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> In the patch, notice the old comment that suggests we might need to use
> CommandCounterIncrement().

... which you failed to fix in any meaningful way.  I'd suggest

    /*
     * Advance the commmand counter to ensure we see all results
     * of current transaction.
     */
    CommandCounterIncrement();

and then change SnapshotSelf to SnapshotNow, since there's no longer any
reason for it to be special.  Compare to CVS tip which already does it
that way.  See also the identical code in write_user_file (which perhaps
has no bug, but ISTM it should stay identical).

            regards, tom lane

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [BUGS] Bug#333854: pg_group file update problems
Next
From: Bruce Momjian
Date:
Subject: Re: [BUGS] Bug#333854: pg_group file update problems